pkg/tinydtls: add IPv4 support #17765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
added
the
CI: ready for build
benpicco
reviewed
Mar 9, 2022
| && uip_ipaddr_cmp(&((A)->addr),&((B)->addr)) \ | ||
| && (A)->ifindex == (B)->ifindex) | ||
| -#elif defined(WITH_RIOT_GNRC) | ||
| +#elif defined(WITH_RIOT) |
There was a problem hiding this comment.
Suggested change
| +#elif defined(WITH_RIOT) | |
| #elif defined(RIOT_VERSION) |
should work as well and doesn't require a custom define (this is used by other pkgs too)
There was a problem hiding this comment.
Ah wait so when RIOT is used with the posix_sockets module this path should not be taken - then how about WITH_RIOT_SOCK
There was a problem hiding this comment.
I renamed WITH_RIOT_GNRC to WITH_RIOT_SOCK as suggested.
|
CI is unhappy |
HendrikVE
force-pushed
the
pr/pkg_tinydtls_ipv4_support
branch
from
f979699 to
7def280
Compare
|
I fixed the compilation for |
Using tinydtls on RIOT OS is not limited to GNRC as network stack. It is also working with e.g. lwIP, see: RIOT-OS#17552 Therefore the name WITH_RIOT_GNRC is misleading.
HendrikVE
force-pushed
the
pr/pkg_tinydtls_ipv4_support
branch
from
7def280 to
d424aae
Compare
|
Thank you very much for your review @benpicco ! |
This was referenced Mar 26, 2022
|
This PR broke |
This was referenced Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Add IPv4 support to
pkg/tinydtls.This PR contains two patches which I will try to get merged in the upstream repository once this PR is merged.
Testing procedure
Can be tested with #17763
Issues/PRs references
Dependencies: